Adnuntius: Send EIDs in URL instead of body #4632
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
adnuntiusRefer here for heat map coverage report |
bsardo
changed the title
ccorbo
approved these changes
Jan 13, 2026
linux019
requested changes
Jan 14, 2026
| q.Set("noCookies", "true") | ||
| } | ||
|
|
||
| if extUser.Eids != nil && len(extUser.Eids) > 0 { |
Contributor
There was a problem hiding this comment.
Suggested change
| if extUser.Eids != nil && len(extUser.Eids) > 0 { | |
| if len(extUser.Eids) > 0 { |
This check is excessive, it also checks nil slice
| var extUser openrtb_ext.ExtUser | ||
| if ortbRequest.User != nil && ortbRequest.User.Ext != nil { | ||
| if err := jsonutil.Unmarshal(ortbRequest.User.Ext, &extUser); err != nil { | ||
| return nil, []error{fmt.Errorf("failed to parse Ext User: %v", err)} |
Contributor
There was a problem hiding this comment.
Suggested change
| return nil, []error{fmt.Errorf("failed to parse Ext User: %v", err)} | |
| return nil, []error{fmt.Errorf("failed to parse Ext User: %w", err)} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ave added the option to read all eids so this change reflects that. Moved from being sent in the body to being sent as a url parameter.